-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Fixed : Docs URL refresh when using side nav issue #9486 #9513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Gitpod works as expected. This fix is also what is recommended for working with Next from headless UI github issue convo. Looks good to me, thanks for the contribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw from the docs they recommend using as
, interested to know people's thoughts?
Yes, using "as" recommended and what we had previously, but if you look further this issue is common when using the next framework and in such case is recommended to use a Link component In reading through the Github Issue here Refresh Issue is how I came to the conclusion that this fix is needed and appropriate in this case as it seems to be an issue within the Headless UI components. wdyt? perhaps I missed something? |
Hi, @eddiejaoude and @amandamartin-dev I made a new solution to fix this issue. We can use headless UI |
Thank you for looking at alternative solutions, but I don't like the idea of a "small hack" 🤔 |
@eddiejaoude bumping my original comment about the initial version of this in the PR since this has been open for a bit now (not the update with the "small hack"). Take a look and lmk what you think |
Thank you for reminding me Amanda 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great collaboration 💪
Fixes Issue
Closes #9486
Changes proposed
Now, the docs side-nav link click will not refresh the full page. All docs pages will load without refreshing the URL.
Check List (Check all the applicable boxes)
Video
BioDrop.-.connect.to.your.audience.with.a.single.link.mp4