-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added notification when no GPSdata is received #16
Conversation
Does anything need doing to this? Otherwise, I can merge when ready. |
I hope this to be mergeable as is ;) |
Sold! Just wanted to give you a chance to revisit it since it has been a little while! 😁 Actually, now that I'm reviewing it, I think it needs a little TLC... it looks like the if for the else is commented out... 😖 |
The |
Awesome thanks! Different editors have different indentation... on mine locally the old was also OK, but I see the bad indentation issue here in GH on my original commit. The text addition is good - thanks! The reason could also be that the GPS support is enabled in firmware, but the GPS is not connected. What do you say to:
? |
Aah, OK, so no detection of physical presence of GPS, just if build option is enabled or not - I get it now. |
Final test on actual hardware matches simu (re: |
Also removed the shadow effect on font to make text better readable.