Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added notification when no GPSdata is received #16

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

rotorman
Copy link
Member

Also removed the shadow effect on font to make text better readable.

@pfeerick
Copy link
Member

Does anything need doing to this? Otherwise, I can merge when ready.

@rotorman
Copy link
Member Author

I hope this to be mergeable as is ;)

@pfeerick
Copy link
Member

pfeerick commented Aug 27, 2021

Sold! Just wanted to give you a chance to revisit it since it has been a little while! 😁 Actually, now that I'm reviewing it, I think it needs a little TLC... it looks like the if for the else is commented out... 😖

@rotorman
Copy link
Member Author

rotorman commented Aug 27, 2021

@pfeerick
Copy link
Member

Yeah, I've just redone the indentation as it was all over the place, so can see it now. Thanks! :)

Do you think this is better, or leave it as it is? (Widget is in two separate panels - big and small - hence the duplication)
snapshot_03

@rotorman
Copy link
Member Author

rotorman commented Aug 27, 2021

Awesome thanks! Different editors have different indentation... on mine locally the old was also OK, but I see the bad indentation issue here in GH on my original commit.

The text addition is good - thanks! The reason could also be that the GPS support is enabled in firmware, but the GPS is not connected. What do you say to:

Make sure you have connected GPS and your firmware has GPS support enabled!

?

@pfeerick
Copy link
Member

pfeerick commented Aug 27, 2021

I added more text - the second and third lines ;) Unless simu acts differently to actual hardware in this instance - building with INTERNAL_GPS gives the following...
snapshot_04

There is still space for at least another line of text, so can add it anyway...

@rotorman
Copy link
Member Author

rotorman commented Aug 27, 2021

Aah, OK, so no detection of physical presence of GPS, just if build option is enabled or not - I get it now.
Thus your original text addition was perfect. Let's leave it at that then.
Thanks!

@pfeerick
Copy link
Member

pfeerick commented Aug 27, 2021

Final test on actual hardware matches simu (re: INTERNAL_GPS / no INTERNAL_GPS behaviour), so unfortunately is that dumb... would have to work off the fix key instead, which isn't so useful... "Either your GPS doesn't have fix yet, or you haven't configured it, it ain't compiled in, or it ain't plugged" ... not so useful! 😆

@pfeerick pfeerick merged commit effdf0a into EdgeTX:master Aug 27, 2021
@rotorman rotorman deleted the patch-1 branch August 27, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants