fix(ui) - Convert theme save and delete dialogs to use ConfirmDialog popup. #3062
Conversation
|
Hi translators,
Please, add your translations. Thank you! |
|
PR created :) |
|
PL |
|
DE |
|
IT |
|
SE |
|
JP |
|
don't forget danish :-) DA |
Thank you :-) |
philmoz
force-pushed
the
theme-save-and-delete
branch
from
b12dcd2 to
c3d42e6
Compare
…ead of full screen alert. Add strings for translation.
philmoz
force-pushed
the
theme-save-and-delete
branch
from
c3d42e6 to
586c478
Compare
|
Confirm dialog is good... but am I missing something... unless I select YES there is no way to leave the theme edit screen now? |
Hmmm. When I select No it closes the dialog and exits the edit screen? |
|
Hm... the github build for 586c478 isn't for me... no returns/stays at the edit screen - can only exit via yes. edit: Same for both TX16S and EL18/NV14... so something weird going on here. Damn... it's either EMing or locking up at power down at times also now. Ok, EM is probably part of original radio theme code... it also just EM'd for #3078 on save, and this isn't the first time I've seen this happen with the theme code. :-/ |
|
The RTN button would exit the dialog without calling the 'cancelHandler' from the theme editor - were you using this? Not sure about the crashing - have not seen this in the simulator. |
|
I think I may have narrowed the EM trigger (on radio) to being somewhat related editing the 'active' theme so will have to try and pin down a reproducable scenario and hope either simu will do it also or set the debugger up again. This was on-screen buttons only - RTN behaved the same. Again, with 586c478 (i.e. before I introduced any changes ;) ) msrdc_AmNX8lnthc.mp4 |
|
Now pressing RTN at the confirm prompt gets me out back to the themes list, but via the touchscreen No it still stays at the edit theme page. |
|
Ok, I get the problem if I flash it to my radio; but it works fine in the Companion simulator ??? |
|
Ouch... so both |
|
Simu on MacOS works ok - does not show the problem. Bizarre! |
|
I use the standalone simulator under Windows and can confirm it. If I make a change and want to close without saving, I remain in the edit screen. It doesn't matter whether I use the standalone simulator or the simulator run from Companion. |
|
If I revert to the full screen dialog then it works as expected on my radio. Testing just now I got the lockup on the radio after using the theme editor and then it rebooted into EM after pulling the battery. Looks like there are a few issues with all this - I will be away for a few days and will look into it next week. |
|
Yes, the theme editor has had more than its share of issues... but slowly getting there. I'll leave this on hold then until we can dig a little deeper. |
|
Had a thought early this morning so one more change to try. |
|
So far no more crashes on my TX16S in the theme editor (touch wood). This last change may have helped here as well. |
|
Agreed... it seems to be back to normal on TX16S/EL18 - can exit the theme editor when choosing no or yes via touch or hard key. No lockup on save or poweroff. I was able to make the TX16S EM again when saving a change to the active theme. However, I was also able to get it to EM when changing from the custom theme to the default theme... so I suspect the issue is specific to reading/writing/applying the theme settings, not this PR. Since the theme editor is actually "pre yaml", it has its own yaml writing implementation, rather than using the ... system version? ... so that could be where that issue is. |
|
CN TW |
* Updated translations, error fixes etc * Minor changes * Minor updates * Update for PR #2998 * Added strings for PR #2998 * Minor error fix * Two new strings translated * Fixed spelling mistake * Another minor fix * Added translations for PR #3062 * Just a few corrections * Add files via upload New translations added * Changes after PR #3119 translation clean up
Use the popup dialog instead of the full screen alert page.
Add strings for translation.