-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for external Multiplex MLink JR type module #3352
Conversation
@pfeerick Thanks for your suggestion. I changed the "NOTLM" sub-type texts to:
|
@pfeerick anything else I can do? can we go ahead with this? |
@mha1 Michael have you checked Companion telemetry sensors tab to ensure new sensors are displayed and with correct units, precision etc? |
@elecpower Neil, thanks for your review. Following your requests I changed PpmSubTypeStrings to
Both new sensors "Acc" and "Spcl" are displayed as expected: |
Need to put this on ice until @raphaelcoeffic works the magic to solve the shared interrupt problem for target Taranis, see #3329 |
Where can I even get such a module? Seems to be discontinued? |
Yes, they are discontinued but you get them second hand as many were sold at the times. The reason why I implemented this is there still is a community out there hanging on to their Multiplex receivers and telemetry stuff using those modules, especially in central Europe. You might ask why they don't use an internal or external MPM as it offers the MLink RF protocol and also handles telemetry. The reasons are mainly distrust in the MPM implementation and more serious legal concerns. Check out the MPM implementation. Even if the MPM MLink RF protocol implementation works fine it is still kinda basic and there is no arguing about that, it is not complying to EU regulations. It implements the RF protocol like an FCC protocol meaning doesn't implement LBT or any other means to comply with EU regulations. The implementation I chose reuses most of the EdgeTX MLink telemetry code for the MPM MLink telemetry. It is basically just a minimal extension to the UI, means of selecting the source of the digital telemetry data (SPort pin) and a simple decoder for the telemetry data as the external module delivers the data in a different format. It also adds two forgotten sensors which are now available for MPM MLink too. All in all it is a low flash memory consuming extension allowing legacy users to migrate their MLink JR modules to a modern radio with EdgeTX. |
Argh draft again, soft serial fix for target Taranis has side effects for some radios e.g. X7 access. |
If soft serial is ready this is ready ... |
I tested this PR again with the latest MAIN+#3329 using Horus X10 Express and Taranis QX7 ACCESS. Everything runs great. |
@pfeerick Sorry to bug you again. This relatively simple PR was tested over and over again after many problems were found (and fixed) not caused by this PR but necessary (not only) for this PR to work. Re-testing included Taranis (X7access, x9d+, x9d+2019), Horus (tx16s, x10access) type radios and of course Companion to cover all bases. So I am confident it'll work fine without any side effects to important stuff. But as the foundation needs to be perfect it is required to merge #3419, #3415 and #3329 too. Please consider a bundled merge into main. 2.9 main of course 😉 |
It should happen soon, 2.8.2 is finally out of the way, so can start thinking about 2.9 again. :) |
U moved to a different continent? |
@pfeerick I think this is good to go too |
force pushed to keep PR up to date after merge of #3329 |
… sensors (is in separate PR too) implemented PPM subtypes in Companion
finalize subtypes for PPM in Companion
…g. NV14), then, if not successfull use soft serial inverted (== uninverted data due to HW inverters on PCB) changed start bit detection IRQ priority from 5 to the previous 0 (also in separate PR)
- "No Telem" for 128x64 (this is the max numbers of characters it can take) - "No Telemetry" everything else including Companion
- lower case 1st charachter on PpmSubTypeStrings to ppmSubTypeStrings - added telemetry hooks for ppmSubTypeStrings stringx
LGTM on TX16S and X9D+2019. telemetry via sport emulator working good, companion reading and writing properly, hope it makes for some happy MLink users :) |
Thank you very much. It takes all kinds to make a world ... To make some kinds happy #3597 needs to be solved too. It was visible on your and Raphael's logic analyzer screenshots but I started counting the channels only yesterday. |
Sometimes it take a while for the penny to drop 🤭 |
I know, patience is a virtue |
This adds support for external Multiplex MLink JR type modules that work on PPM and are able to deliver digital telemetry data (like Multiplex HFMG3 M-LINK 2,4 GHz HF-Module)
Summary of changes radio:
Summary of changes Companion:
Radio:
Companion:
Yaml radio and Companion: