feat(radio) - Add options to disable radio and model menu tabs. #3484
Conversation
|
Before I start on the B&W and Companion changes, please let me know if this is what you were after. |
|
Oh, interesting, I was wondering if there was any benefit to extending it to the radio tabs... I'll have to try it out later today, but from the screenshots that looks perfect :) |
|
pls add heli option so there is no need to separate 2 firmware anymore |
|
That is the main reason for this change 😉 |
|
Would "visible Tabs" describe it better than "view options"? |
|
TBH I'm not a fan of 'View Options'. It's possible the properties could control more than just the tab visibility. Perhaps 'Features' might be a better name? |
|
Well, since it now does more than configure view options, that probably doesn't fit any more. But "Features" is not very descriptive :-P What features? Why would I want to press it? |
|
I wonder if numerous compile time options, such as e.g. HELI and GVARS, could be fully removed with this PR. |
|
Hopefully yes, but I think that will be a later task - as we may need them still right now for the smaller targets, especially as some of the translated builds can be slightly bigger without disabling some features. Hopefully, the savings from the removal of binary conversion has alleviated that pain for 2.9. |
|
Those settings also cost RAM, so some people will complain, that there is less available RAM. |
|
Added B&W radio support - that was fun ;)
|
|
Added code to collapse timer sections on model setup when timer is off. Fixes issue #3016
|
|
Added expand/collapse feature to the throttle, preflight checks and view options sections. Fixes issue #3017
|
|
Added Companion UI. Note: this is only for updating the radio & model properties. It does not affect the tabs in the Companion radio or model editors. I.E. turning off Flight Modes does not hide the flight mode tab in the Companion Model editor. I'm not sure this is necessary (or how to do it).
|
Nope, not at all. Radio properties is more than enough. Damn, you're on fire with this one! :) Can I ask what the justification was for being able to turn the Mixes tab off... Just curious as to the rationale, as without that, it pretty much makes it impossible to set a model up. Perhaps a box around the View options controls, just to show they're all related, like with the sections above? |
I was asking myself the same @philmoz great work! |
That would be me mis-interpreting what was written in issue #1692 I'll take this one out :) |
|
@philmoz Companion suggestion to put new settings on their own tabs. If you agree I'm happy to do it for you. Companion should take note of the settings as this has come up at times but less important since navigation is easier on a computer. Best to leave any redesign work until after we get Qt 6 implemented and there are also other changes to support requested functionality. |
Yes, my apologies, it did mean custom mixer scripts. 😵💫 I was just thinking maybe there was a reason someone would want to turn the mixes off... but chop chop for now unless there is a good reason (at which point it can be added later). |
@elecpower - If you can make it prettier or easier to use go for it. I've removed 'Mixes' from the list so this should be done (barring any bugs). |
|
@philmoz see my branch https://github.com/elecpower/edgetx/tree/view-options for Companion Ui mods In testing I noticed that Custom Mix Scripts is not shown on X9D+ or TX16S libsims. Should it also be removed from Companion for all radios? |
Thanks, will take a look.
Custom mix scripts requires a custom radio build option; but I could not see any equivalent in Companion (like noheli or nogvars). I opted to leave it in; but I have no objection to removing it. |
As far as I am concerned, a plausible reason might be to provide the tx to someone already well set up and not easily give him or her the chance to twist something that might, for example, cause problems in the flight of a model. |
|
Everything that has an impact should be visible or else you are searching for the cause of some strange behavior, but it is hidden away by a disabled tab. |
|
Latest commit uses the 'view options' flags to control other functionality:
(Really need a better name than 'View Options' now). |
How about "Visible tabs" or "Tabs visible:" ? |
|
Since it now also disabled the functionalities, how about |
…llapse (default collapsed).
…AML files. Fix scrolling for radio setup view options.
- skip heli mixer logic if heli not enabled - Remove heli, gvars and telemetry options from source selection if not enabled
…ut & mix editors if option disabled.
Put GVAR option under Flight Mode and indent text. Make relationship between FM and GV more obvious.
Hide FM1-FM8 in global variables if flight modes hidden.
|
Can we also do the translations here? |
|
It's already merged, but I'll add any that are done here ;) |
|
There is still a small problem in Companion. If I edit e.g. the fifth model in the list of models, click on the tab "Enabled Feature" and set e.g. "Heli" from "Global" to "On" under Model Menues, the focus jumps away from the selected model to the first model in the list. |
|
I don't believe that is related to this PR. If I go to Companion 2.8 (i.e. not even a recent 2.9), and make some change in the model settings there, focus is "lost" there also, so it seems to be a general Companion behaviour when you work in another modal dialog. |
Ah, okay thank you. |
Why the dashes in the last two, and no dashes in the first one? Including them looks wrong to me, so I prefer the first option. |
|
DE: |
|
@pfeerick |
Resolves #1692, resolves #3016, resolves #3017 and #1249
Summary of changes:
TODO:
Notes: