Review IT #3505
Merged
Review IT #3505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did you test this on ColoLCD and B&W targets, to check if the translations fit on the screen? |
Nope, couldn't test but i tried to keep same lenght as english, in any case shorter. |
|
It's okay with me, nice job, thanks. Update V2.9.x by: Marco Robustini [email protected] - Fix V2.9.x by: MatCron [email protected] |
|
Thanks Marco :) I'll see what the conflict is and get this merged soon. And thanks for the review Pancronos, more native language eyes the better :) |
Signed-off-by: Pancronos <[email protected]>
pfeerick
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pancronos [email protected]
Fixes #
Summary of changes: