-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hebrew radio translation 🇮🇱 #3506
Conversation
1bd8981
to
b6c4c73
Compare
LVGL has even more RTL-Support. It should be possible to reverse the inputelement and description order automatically, depending on the language. |
Can we do that in a separate PR? |
b6c4c73
to
8566ccd
Compare
That sounds fine with me... this is a start. My only concern would be the inclusion of the Arial font... isn't that a copyrighted font? i.e. belonging to the The Monotype Corporation? |
we check it.. |
That would be the goal - other than the font issue, this PR in its current form seems looks to be a good enough start, and we can then get some feedback as to what else is needed. |
1a2e7e6
to
1be7420
Compare
LGTM... assuming no build issues, and you guys are happy with the current state of this (given you're the native language guys, not me 🤭 ) I think this can get merged. |
1be7420
to
f9dd669
Compare
Did a couple of local builds to make sure everything is building properly, seems to be fine. I can see some strings still need translating, but that is to be expected. When you're happy with this PR, can you add
to around line 107 of |
Replaced Arial font with Arimo from Google (Apache 2.0 license). |
Thanks for the support @pfeerick! |
Add Hebrew support, fonts and translations