Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hebrew radio translation 🇮🇱 #3506

Merged
merged 4 commits into from
May 14, 2023
Merged

Conversation

stavfx
Copy link
Contributor

@stavfx stavfx commented Apr 21, 2023

Add Hebrew support, fonts and translations

image
image
image

@stavfx stavfx force-pushed the translation-hebrew branch 2 times, most recently from 1bd8981 to b6c4c73 Compare April 22, 2023 23:08
@gagarinlg
Copy link
Member

LVGL has even more RTL-Support. It should be possible to reverse the inputelement and description order automatically, depending on the language.

@stavfx
Copy link
Contributor Author

stavfx commented May 6, 2023

Can we do that in a separate PR?
This is a step in the right direction that people are happy to work with

@pfeerick pfeerick force-pushed the translation-hebrew branch from b6c4c73 to 8566ccd Compare May 11, 2023 00:58
@pfeerick
Copy link
Member

That sounds fine with me... this is a start. My only concern would be the inclusion of the Arial font... isn't that a copyrighted font? i.e. belonging to the The Monotype Corporation?

@pfeerick pfeerick added translation color Related generally to color LCD radios labels May 11, 2023
@adir-kro
Copy link

adir-kro commented May 11, 2023

That sounds fine with me... this is a start. My only concern would be the inclusion of the Arial font... isn't that a copyrighted font? i.e. belonging to the The Monotype Corporation?

we check it..
Do you intend to add the Hebrew to the upcoming version 2.9?

@pfeerick
Copy link
Member

That would be the goal - other than the font issue, this PR in its current form seems looks to be a good enough start, and we can then get some feedback as to what else is needed.

@stavfx stavfx force-pushed the translation-hebrew branch 4 times, most recently from 1a2e7e6 to 1be7420 Compare May 13, 2023 07:00
@pfeerick
Copy link
Member

LGTM... assuming no build issues, and you guys are happy with the current state of this (given you're the native language guys, not me 🤭 ) I think this can get merged.

@stavfx stavfx force-pushed the translation-hebrew branch from 1be7420 to f9dd669 Compare May 13, 2023 07:06
@pfeerick
Copy link
Member

Did a couple of local builds to make sure everything is building properly, seems to be fine. I can see some strings still need translating, but that is to be expected. When you're happy with this PR, can you add

addLanguage("he");

to around line 107 of companion/src/firmwares/opentx/opentxinterface.h (have a look at #3587 if you need a reference) so that Companion also knows about the Hebrew language setting.

@pfeerick pfeerick added this to the 2.9 milestone May 13, 2023
@stavfx
Copy link
Contributor Author

stavfx commented May 13, 2023

Replaced Arial font with Arimo from Google (Apache 2.0 license).
Added addLanguage("he"); as instructed. We are all set.

@pfeerick pfeerick merged commit dd64aae into EdgeTX:main May 14, 2023
@stavfx
Copy link
Contributor Author

stavfx commented May 14, 2023

Thanks for the support @pfeerick!

@stavfx stavfx deleted the translation-hebrew branch September 11, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color Related generally to color LCD radios translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants