CPN: user configurable audio mute in radio settings. Supports PR #3703 #3710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to make checkbox only visible for radios with AUDIO_MUTE_GPIO pin (see target/hal.h files):
|
|
@elecpower Can you give this a glance over, and let me know if you're happy with it? I'll give the combined two PRs a try tomorrow. |
|
@pfeerick looks okay |
- All color lcd radios (including NV14) except Horus X12S - TX12, TX12MK2, ZORRO, BOXER, T8, TLITE, TPRO, LR3PRO, COMMANDO8
pfeerick
force-pushed
the
PR_CPN_audioMuteEnable
branch
from
3bbf291 to
2b5d245
Compare
pfeerick
pushed a commit
that referenced
this pull request
Jun 30, 2023
* CPN: user configurable audio mute in radio settings. Supports PR #3703 * make checkbox only visible for radios with AUDIO_MUTE_GPIO pin: - All color lcd radios (including NV14) except Horus X12S - TX12, TX12MK2, ZORRO, BOXER, T8, TLITE, TPRO, LR3PRO, COMMANDO8
pfeerick
added a commit
that referenced
this pull request
Jul 1, 2023
* feat(cpn): User configurable audio mute in radio settings (#3710) * CPN: user configurable audio mute in radio settings. Supports PR #3703 * make checkbox only visible for radios with AUDIO_MUTE_GPIO pin: - All color lcd radios (including NV14) except Horus X12S - TX12, TX12MK2, ZORRO, BOXER, T8, TLITE, TPRO, LR3PRO, COMMANDO8 * chore: Add Companion translations --------- Co-authored-by: Michael <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds user configurable audio mute in CPN's radio setting. Supports PR #3703