-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(telemetry): process DSM LIPO Cells Monitor sensor correctly #4720
Conversation
1. Fix processing of message 0x3A 2. Fix Temperatures to have no decimals, otherwise they will not convert correctly between C/F.
Thanks you for your job :-) |
|
Sorry, i don't understand what is the PR page (too french :-). |
OOps PULL REQUEST ? |
Sorry, yes, Pull Request. You are there/here already. |
Ok, i have found thanks |
@pfeerick don't merge it yet.. I think by fixing #4723 will allow to have temperatures using decimal places. |
Removing the Temp to Prec0 conversion, it will be handled properly by another PR.
Optimization on Traversing the sensor table. Since the table is sorted by the message i2cAddress, once we are past that sensor, we can stop. TODO: Future optimization: create an index to get to the start of the sensor in the table much faster.
Fixes #4715
Summary of changes:
Fix processing of message 0x3A: