Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cpn): model semver check inc model name in warning msg #4794

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

elecpower
Copy link
Collaborator

Fixes #4768 part 2 adding model name to version check message

Screenshot from 2024-03-24 13-50-18

@elecpower elecpower added bug 🪲 Something isn't working companion Related to the companion software labels Mar 24, 2024
@elecpower elecpower changed the title fix(cpn): model semver check inc model name in waring msg fix(cpn): model semver check inc model name in warning msg Mar 24, 2024
@pfeerick pfeerick added this to the 2.10 milestone Mar 24, 2024
@elecpower
Copy link
Collaborator Author

For another time I need to remove the acknowledge message and change the buttons to Accept and Decline

@pfeerick
Copy link
Member

Sounds good. The generalsettings prompt will want the same treatment also ;)

@pfeerick pfeerick merged commit a791bf2 into main Mar 24, 2024
3 checks passed
@pfeerick pfeerick deleted the elecpower/cpn-fix-4768-pt2 branch March 24, 2024 03:34
ThomasKuehne pushed a commit to ThomasKuehne/edgetx that referenced this pull request Mar 24, 2024
felipemanga pushed a commit to felipemanga/edgetx that referenced this pull request Mar 29, 2024
ThomasKuehne pushed a commit to ThomasKuehne/edgetx that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working companion Related to the companion software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants