Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(color): selected label, model list not correctly updating in single select mode #5048

Merged
merged 2 commits into from
May 23, 2024

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented May 22, 2024

In single select mode, adding new labels, deleting labels and moving labels does not update the selected label and model list correctly.

This is the fix for 2.10.

@philmoz philmoz changed the title fix(color): issues with label management in single select mode. fix(color): issues with label management in single select mode (2.10). May 22, 2024
@pfeerick pfeerick added this to the 2.10.1 milestone May 23, 2024
@pfeerick pfeerick added bug 🪲 Something isn't working color Related generally to color LCD radios labels May 23, 2024
@pfeerick
Copy link
Member

Should moving labels up and down really change the label in focus though?

@philmoz
Copy link
Collaborator Author

philmoz commented May 23, 2024

Should moving labels up and down really change the label in focus though?

Hopefully fixed now (also in 5049).

@pfeerick
Copy link
Member

Thanks, that seems better

@pfeerick pfeerick changed the title fix(color): issues with label management in single select mode (2.10). fix(color): selected label, model list not correctly updating in single select mode May 23, 2024
@pfeerick pfeerick merged commit 074224a into 2.10 May 23, 2024
44 checks passed
@pfeerick pfeerick deleted the philmoz/fix-single-select-labels branch May 23, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working color Related generally to color LCD radios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants