Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: xjt lite telem binding #5468

Merged
merged 6 commits into from
Aug 28, 2024
Merged

fix: xjt lite telem binding #5468

merged 6 commits into from
Aug 28, 2024

Conversation

3djc
Copy link
Collaborator

@3djc 3djc commented Aug 21, 2024

External module FrSky telem binding should only be disabled when internal module is already using sport.

This fixes #5466

@3djc 3djc requested a review from raphaelcoeffic August 21, 2024 09:02
@pfeerick pfeerick added this to the 2.10.4 milestone Aug 21, 2024
@pfeerick pfeerick added the bug/regression ↩️ A new version of EdgeTX broke something label Aug 21, 2024
@3djc
Copy link
Collaborator Author

3djc commented Aug 21, 2024

@pfeerick Raph is ok with the change, but don't merge just yet, I'll add unit test

@pfeerick pfeerick added the needs: unit tests Unit tests are needed to for continuous validation label Aug 21, 2024
@pfeerick
Copy link
Member

Thanks JC :)

@pfeerick pfeerick merged commit 1852c8c into main Aug 28, 2024
28 checks passed
@pfeerick pfeerick deleted the 3djc/fix-5466 branch August 28, 2024 02:59
pfeerick pushed a commit that referenced this pull request Aug 28, 2024
@pfeerick pfeerick added unit tests 🧪 and removed needs: unit tests Unit tests are needed to for continuous validation labels Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression ↩️ A new version of EdgeTX broke something unit tests 🧪
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RXSR receiver can't be bind with telemetry using D16
2 participants