Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cpn): sf/gf sd logs minimum and default time #5561

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

elecpower
Copy link
Collaborator

Fixes #5451 but not documentation!

Summary of changes:

  • set minimum time to 0.1s
  • set default time to 1.0s

@elecpower elecpower added bug 🪲 Something isn't working companion Related to the companion software labels Sep 24, 2024
@elecpower elecpower added this to the 2.11 milestone Sep 24, 2024
@elecpower
Copy link
Collaborator Author

elecpower commented Sep 26, 2024

This could also go into 2.10.5 if it gets released

@pfeerick pfeerick changed the title Fix(cpn): sf/gf sd logs minimum and default time fix(cpn): sf/gf sd logs minimum and default time Sep 26, 2024
@pfeerick pfeerick modified the milestones: 2.11, 2.10.5 Sep 26, 2024
@pfeerick
Copy link
Member

It is on the agenda, so np there.

@pfeerick pfeerick added the user manual change Will impact on the user manual in some respect label Sep 29, 2024
@pfeerick pfeerick merged commit e9430ec into main Sep 29, 2024
3 checks passed
@pfeerick pfeerick deleted the elecpower/cpn-fix-5451 branch September 29, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working companion Related to the companion software user manual change Will impact on the user manual in some respect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SD Logs: Value cannot be cleared
2 participants