-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(color): allow all UI controls for widgets when full screen #5808
base: main
Are you sure you want to change the base?
Conversation
731932e
to
8f861ec
Compare
9ef3bee
to
aa5a078
Compare
Many thanks for your great work! Most stuff was already discussed on discord. Just not to get lost I mention the following issues I actually see:
|
Slider and toggle switch fixed. A note on the lvgl.getContext() function. |
Confirm with my test app. Thanks!!!
Ok, maybe need only a docu fix then.
Cool, will also have a look at that. |
Added 'momentaryButton' control: {type="momentaryButton", text="Title", press=(function() end), release=(function() end)} Shows in checked state while pressed. |
Wow! Absolute great work. Many thanks. First tests are successful ;-) |
Just an idea for a small improvement (in my eyes): the UI classes That said, I would it find useful to override the default colors (from theme). The |
Great addition For ease of documentation, it will be better as buttonMomentarySo it will be sorted alphabetically (docs/web site/auto completion)Can the edgeTx used that button instead of the regular in the numbers editor (-10, -1, +1, +10)?—————————Offer ShmuelyOn 24 Jan 2025, at 16:58, Wilhelm ***@***.***> wrote:
Just an idea for a small improvement (in my eyes):
the UI classes button and momentaryButton share the same screen layout - they are visually indistinguishable. I would prefer to have different looks for them, to say: the momentaryButton should get another layout (maybe italic font or not a rounded rectangle).
That said, I would it find useful to override the default colors (from theme). The color property for e.g. button is ignored. Maybe there could be textColor, fgColor, bgColor that override the theme defaults.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@wimalopaan - the momentary button was your idea, do you have any preference for how it is named? Now would be the time to change it. |
@JimB40 - do you have any thoughts on this? |
I would still vote for |
…ss in full screen.
8c192f2
to
0de975f
Compare
Extends the Lua LVGL API to allow buttons, text and number edit, sliders etc to be used on widgets when the widget is in full screen mode.
Example widget script: