feat(sim): startup can be slow when scanning SYSTEM audio files #5822
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfeerick
changed the title
philmoz
force-pushed
the
philmoz/speed-up-simu-start
branch
from
c6befe6 to
88e6174
Compare
|
I'm seeing a nice improvement here also on Windows...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simulator f_readdir() function calls f_stat for each file in the directory.
This can be slow especially on network drives when the code is scanning the SYSTEM sounds folder, looking for the system sounds.
This PR changes the logic for the simulator to loop over the system sound files names, calling f_stat() for each one.
On my Mac this reduces the sound file scan time from 5.7s to 1.4s when reading from a NAS drive.