chore(dsm): remove always zero sensors, use thread safe functions #5835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove "sprintf" and use more basic and efficient functions. looks like sprintf uses malloc that is not recommended to be used in the telemetry thread.
Remove Smart battery sensors who are not used or always come as 0.
Fix typo
|
Before: |
remove trying to decode SmartBattery ID info as well as Charging Limits
|
After: |
frankiearzu
changed the title
pfeerick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5834
Summary of changes:
Replace calls for "sprintf" who internally use "malloc" for more basic formatting and concatenation functions. Someone recommended this change since malloc could not be thread-safe for the telemetry thread.
Remove unused (or always 0) Smart Battery sensors. Even after using a "smart" charger with "smart" batteries, seems that they are not populating the telemetry values properly.
This helps reduce the list of sensors, especially useful for B&W radios.