Made Ref, SynchronizedRef,RcRef, and SubscriptionRef a subtype of Effect`

[KhraksMamtsov]

Type

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

Description

Related

• Related Issue DX improvement: Support yield* in even more places: Fibers, Deferreds, ... #3500
• Closes #

[changeset-bot]

🦋 Changeset detected

Latest commit: 47e9fa1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages

Name	Type
effect	Minor
@effect/cli	Major
@effect/cluster-browser	Major
@effect/cluster-node	Major
@effect/cluster-workflow	Major
@effect/cluster	Major
@effect/experimental	Major
@effect/opentelemetry	Major
@effect/platform-browser	Major
@effect/platform-bun	Major
@effect/platform-node-shared	Major
@effect/platform-node	Major
@effect/platform	Major
@effect/printer-ansi	Major
@effect/printer	Major
@effect/rpc-http	Major
@effect/rpc	Major
@effect/schema	Major
@effect/sql-d1	Major
@effect/sql-drizzle	Major
@effect/sql-kysely	Major
@effect/sql-mssql	Major
@effect/sql-mysql2	Major
@effect/sql-pg	Major
@effect/sql-sqlite-bun	Major
@effect/sql-sqlite-node	Major
@effect/sql-sqlite-react-native	Major
@effect/sql-sqlite-wasm	Major
@effect/sql	Major
@effect/typeclass	Major
@effect/vitest	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[tim-smart]

I wonder if making Readable a sub-type of Effect is more appropriate.

[KhraksMamtsov]

If I make Readable a subtype of Effect this error arise:

Readable looks more like mixin or trait - and only finalized types should be Effect's subtypes

Also where is problem with Unify - now it is designed to work with covariant types
But since *Ref has an invariant type parameter, this does not work

type Test = Unify<Ref<1> | Ref<"a">> // Ref<1> | Ref<"a"> | Ref<1 | "a">

because Unify uses ... | Exclude<X, Z> | ... and Exclude<Ref<in out 1> | Ref<in out 'a'>, Ref<in out 1 | 'a'> takes no effect

[KhraksMamtsov]

I figured out with Unify module - all invariant types must remain as they are
add dtslint tests

[KhraksMamtsov]

@tim-smart Could you please tell me if this is a move in the right direction? or is the correct implementation much more complicated than this approach? Thank you

[tim-smart]

I'm still not sure if I like having Ref's a subtype of Effect, it feels a bit strange. If others like it I'm happy to be veto'ed though.

[mikearnaldi]

I'm still not sure if I like having Ref's a subtype of Effect, it feels a bit strange. If others like it I'm happy to be veto'ed though.

kind of goes in the same direction of having Option be an Effect

[mikearnaldi]

I suppose we can accept for now and if we don't like it revise in 4.0

[KhraksMamtsov]

kind of goes in the same direction of having Option be an Effect

yes, after turning Option and Either into an Effect, the other subtypes don't look so wild, but even more ergonomic. It seems to be the next logical step.

[mikearnaldi]

kind of goes in the same direction of having Option be an Effect

yes, after turning Option and Either into an Effect, the other subtypes don't look so wild, but even more ergonomic. It seems to be the next logical step.

indeed, followed by Deferred and Fiber