Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies #520

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Conversation

mi-hol
Copy link
Contributor

@mi-hol mi-hol commented Sep 8, 2024

With recent changes 2 dependencies became unused.
I went ahead and removed them but have no possibility to test the created bin yet!
Build action https://github.com/mi-hol/HeishaMon/actions/runs/10759232099 is successful

@mi-hol
Copy link
Contributor Author

mi-hol commented Sep 8, 2024

@IgorYbema looking at .github/workflows/main.yml
the command line is now:
run: arduino-cli lib install ringbuffer pubsubclient arduinojson dallastemperature onewire "Adafruit NeoPixel"

Therefore the open question is:
Is platformio.ini actually used?

@IgorYbema
Copy link
Contributor

No and I don't know how that got into the repo

@geduxas
Copy link
Contributor

geduxas commented Sep 8, 2024

@IgorYbema looking at .github/workflows/main.yml the command line is now: run: arduino-cli lib install ringbuffer pubsubclient arduinojson dallastemperature onewire "Adafruit NeoPixel"

Therefore the open question is: Is platformio.ini actually used?

No platformIO is not used. #376 is all it's history.

@mi-hol
Copy link
Contributor Author

mi-hol commented Sep 8, 2024

thanks for clarification, I've amended PR accordingly

@Egyras Egyras merged commit 99749aa into Egyras:master Sep 9, 2024
1 check passed
@mi-hol mi-hol deleted the removeUnusedDependencies branch September 11, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants