-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1511] Refactor account representation from int to a dedicated account structure #1515
Conversation
… to a dedicated Account structure - First iteration of all Int account references to an instance of an Account
- The ID of account is now public co clients can read-only it
- Zip32 accounts represented with Int32 are now refactored to Zip32Account - from_account_id/fto_account_id are now refactored to AccountId
Example/ZcashLightClientSample/ZcashLightClientSample/Send/SendViewController.swift
Outdated
Show resolved
Hide resolved
Sources/ZcashLightClientKit/Block/Actions/SaplingParamsAction.swift
Outdated
Show resolved
Hide resolved
Sources/ZcashLightClientKit/Rust/ZcashKeyDerivationBackendWelding.swift
Outdated
Show resolved
Hide resolved
Sources/ZcashLightClientKit/Rust/ZcashKeyDerivationBackendWelding.swift
Outdated
Show resolved
Hide resolved
Sources/ZcashLightClientKit/Rust/ZcashKeyDerivationBackendWelding.swift
Outdated
Show resolved
Hide resolved
Sources/ZcashLightClientKit/Rust/ZcashKeyDerivationBackendWelding.swift
Outdated
Show resolved
Hide resolved
Tests/OfflineTests/DerivationToolTests/DerivationToolMainnetTests.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested.
- Zip32Account(Int32) has been refactored to Zip32AccountIndex(UIn32)
- WalletSummary's accountBalances dictionary has been refactored to use Zip32AccountIndex instead of UInt32 for the keys
Sources/ZcashLightClientKit/Rust/ZcashKeyDerivationBackend.swift
Outdated
Show resolved
Hide resolved
Sources/ZcashLightClientKit/Rust/ZcashKeyDerivationBackend.swift
Outdated
Show resolved
Hide resolved
Sources/ZcashLightClientKit/Transaction/TransactionEncoder.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK with blocking comments.
- Some comments updated to reflect reality - Some Tests fixed
670f2ce
into
Electric-Coin-Company:1514-Finish-multi-account-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Post-hoc ACK 6505d5f
Closes #1511
DerivationTool
uses accountIndex: Int32from_account_id
/to_account_id
refactored to AccountId(Int)This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author
Reviewer