-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, I'll try it out today as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I've got a few notes though.
- I checked out this branch, rebased it on master, and ran
npm run lint
and got this warning.Warning: React version not specified in eslint-plugin-react settings. See https://github.com/jsx-eslint/eslint-plugin-react#configuration .
You can silence this if you add the following to.eslintrc.json
.
"settings": {
"react": {
"version": "detect"
}
}
- Could you take a look at the lining errors and maybe fix them? Else we will have a check in the CI soon that always fails.
- Please run
npm run format
, commit it, and add the commit hash with a brief comment to.git-blame-ignore-revs
file.
https://www.stefanjudis.com/today-i-learned/how-to-exclude-commits-from-git-blame/#ignore-commits-via-%60--ignore-revs-file%60
For 2. and 3. please rebase this branch on master.
npm run lint-staged | ||
npm run build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you only split this up but did not write it.
I have heard that people turn this hook off because building the front end on each commit takes too much time.
It would make more sense to get rid of the build part, only run formatting and lining and let the CI make sure the project can build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, I took care of it with this PR.
#159
Forget point 3.
Seems like Markus wants to wait with it. |
@Benjaminimal great work :) |
It can stay open, hopefully we are soon done with the milestone and then we can merge it. |
Ahh, now I see, it got obsolete because of #160? So I'll close it again. |
Ref: #98
These changes seem to work on my end now.
I also added two more npm scripts to be invoked from the CI job.
Could someone please verify it?
Basics
(first line should have
module: short statement
syntax)close #X
, are in the commit messages.Checklist
(not in the PR description)
Review