Skip to content

Commit

Permalink
Radio: support switching radio with keyborard in ff. Fixes #8198 (#1…
Browse files Browse the repository at this point in the history
…1325)

* Docs: fix docs of Tab-pane

* Radio: support switching radio with keyborard in ff. Fixes #8198
  • Loading branch information
jikkai authored and Leopoldthecoder committed May 24, 2018
1 parent df7bbe2 commit ada80e6
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion examples/docs/en-US/tabs.md
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@ Only card type Tabs support addable & closeable.
| disabled | whether Tab is disabled | boolean || false |
| name | identifier corresponding to the activeName of Tabs, representing the alias of the tab-pane | string || ordinal number of the tab-pane in the sequence, e.g. the first tab-pane is '1' |
| closable | whether Tab is closable | boolean || false |
| lazy | whether Tab is lazy to render | boolean || false |
| lazy | whether Tab is lazily rendered | boolean || false |
2 changes: 1 addition & 1 deletion examples/docs/es/tabs.md
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@ Solo las pestañas de tipo tarjeta soportan adición y cierre.
| disabled | si la Tabulación está deshabilitada | boolean || false |
| name | identificador correspondiente al activeName de la Tabulación, representando el alias del tab-pane | string || número ordinal del tab-pane en la secuencia, p.ej el primer tab-pane de pestañas es '1' |
| closable | si el Tab es cerrable | boolean || false |
| lazy | whether Tab is lazy to render | boolean || false |
| lazy | whether Tab is lazily rendered | boolean || false |
4 changes: 4 additions & 0 deletions packages/radio/src/radio-group.vue
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,10 @@
e.preventDefault();
if (index === 0) {
roleRadios[length - 1].click();
roleRadios[length - 1].focus();
} else {
roleRadios[index - 1].click();
roleRadios[index - 1].focus();
}
break;
case keyCode.RIGHT:
Expand All @@ -84,8 +86,10 @@
e.stopPropagation();
e.preventDefault();
roleRadios[0].click();
roleRadios[0].focus();
} else {
roleRadios[index + 1].click();
roleRadios[index + 1].focus();
}
break;
default:
Expand Down
2 changes: 1 addition & 1 deletion types/tab-pane.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ export declare class ElTabPane extends ElementUIComponent {
/** Whether Tab is closable */
closable: boolean

/** Whether Tab is lazy to render */
/** Whether Tab is lazily rendered */
lazy: boolean
}

0 comments on commit ada80e6

Please sign in to comment.