Pagination: handle NaN on props #10623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -375,27 +375,30 @@ export default { | |||
| pageSize: { | |||
| immediate: true, | |||
| handler(val) { | |||
| this.internalPageSize = val; | |||
| this.internalPageSize = isNaN(val) ? 10 : val; | |||
There was a problem hiding this comment.
Hi, I think it should be 1, right?
There was a problem hiding this comment.
Hey! I though it was 10 because pageSize's default value is 10 as written on prop type definitions.
Am I missing something? Sorry, I'm kind of new to this part.
Leopoldthecoder
approved these changes
Apr 9, 2018
bluejfox
added a commit
to setariajs/setaria-ui
that referenced
this pull request
Apr 16, 2018
Merge commit 'e344b24efff83e35ed424f073e3141a3e7068595' into current * commit 'e344b24efff83e35ed424f073e3141a3e7068595': (60 commits) Changelog: fix a 2.3.4 typo (ElemeFE#10710) Changelog: update for 2.3.4 (ElemeFE#10703) [release] 2.3.4 [build] 2.3.4 Changelog: update for 2.3.4 (ElemeFE#10691) Rate: fix a method name typo (ElemeFE#10688) Types: add missing CheckboxButton export (ElemeFE#10666) Table: add $index as formatter's param (ElemeFE#10645) Tabs: fix text color for disabled border-card (ElemeFE#10640) Select: fix tags style in IE10 (ElemeFE#10632) Textarea: fix undefined in ssr when v-model not set (ElemeFE#10630) Pagination: disabled prev and next buttons should not trigger click (ElemeFE#10628) Pagination: handle NaN on props (ElemeFE#10623) Upload: fix duplicated handleClick due to keydown bubbling (ElemeFE#10624) Select: fix a wrong variable name (ElemeFE#10618) Table: update resizeState when updateColumnsWidth (ElemeFE#10338) Pagination: ensure currentPage is updated in current-change handler (ElemeFE#10599) i18n: fix a typo in pl.js (ElemeFE#10593) Radio: remove native input's offset of radio button (ElemeFE#10592) i18n: add ug-CN (ElemeFE#10585) ... # Conflicts: # CHANGELOG.zh-CN.md # examples/versions.json # package.json # src/index.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Pagination component breaks when
NaNis passed on the propcurrentPageorpageSize. Here is a demo reproducing the issue.https://jsfiddle.net/xroupdkf/2/
I added a little protection code to keep it safe from
NaN.NaN,pageSizereturns default value (which is10).currentPagealready had a nice handling code insideinternalCurrentPagewatcher but it is not invoked at initial phase, so I made it to be called immediately.It passes all of the test cases and I added more of it.
Thank you for maintaining this amazing repository.