Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading: add missing definition of directive #11749

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Loading: add missing definition of directive #11749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions types/loading.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ export interface ElLoading {

/** If you do not have a specific DOM node to attach the Loading directive, or if you simply prefer not to use Loading as a directive, you can call this service with some configs to open a Loading instance. */
service (options: LoadingServiceOptions): ElLoadingComponent

directive: object
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a ElLoadingDirective interface above at line 37
this line isn't suppose to be directive: ElLoadingDirective
i'm not 100% sure tho, but please check

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and i believe there are more directives missing typings, other than this one, so better check across entire project.

}

declare module 'vue/types/vue' {
Expand Down