New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert: if <el-alert> uses slot, the icon should use 'isBigIcon' class #6612

Merged

Leopoldthecoder merged 1 commit into ElemeFE:dev from leezng:dev-alert

Aug 22, 2017

Contributor

leezng commented Aug 21, 2017 •

edited

Loading

Make sure you follow Element's contributing guide (中文 | English).
Make sure you are merging your commits to dev branch.
Add some descriptions and refer relative issues for you PR.


          fixed el-alert: if using slot, icon should use 'isBigIcon' class

75d7435

Leopoldthecoder approved these changes

View reviewed changes

Leopoldthecoder merged commit f7b08a9 into ElemeFE:dev

leezng deleted the dev-alert branch

October 9, 2017 08:44

daggerjames commented Oct 24, 2017

对此commit有异议(或新需求？)：
如果alert的内容包含链接，需要用html写入。此时可以通过设置title=‘’，然后slot里面注入链接，如

<el-alert title=''>
 <p>这是一个含链接的提示<a href='sss'>我是链接</a></p>
</el-alert>

更新后发现此时单行文字用了 isBigIcon.

建议设置 title允许以slot载入，或者show-icon属性接受传入值? 目前我为了在自己的项目hack掉这个修正，只能不使用默认的show-icon，在slot里面自己使用图标。

如需我帮忙提交pull request，请注明element这边倾向的解决方法

@Leopoldthecoder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet