fix "last item been overlapped by DateTimePicker's footerbar bug" when sidebar items are too more。 #7567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix "last item been overlapped by footbar bug" when sidebar items are two more。even overflow can not resolve this problem, it is not the same thing. the details you can see https://dulinrain.github.io/elementui/ElementUI%E4%B9%8B%E6%97%B6%E9%97%B4%E6%8F%92%E4%BB%B6Bug.html
DuLinRain
changed the title
|
|
||
| .el-picker-panel__body-wrapper { | ||
| position: relative; | ||
| } |
There was a problem hiding this comment.
This breaks the style of DatePicker. Please move this to date-picker.css, inside date-picker block:
&.has-time .el-picker-panel__body-wrapper{
position: relative;
}There was a problem hiding this comment.
ok, I have done it as your review.
Leopoldthecoder
approved these changes
Oct 23, 2017
element-bot
added a commit
to ElementUI/dev
that referenced
this pull request
Oct 23, 2017
…7567) * Update picker-panel.css fix "last item been overlapped by footbar bug" when sidebar items are two more。even overflow can not resolve this problem, it is not the same thing. the details you can see https://dulinrain.github.io/elementui/ElementUI%E4%B9%8B%E6%97%B6%E9%97%B4%E6%8F%92%E4%BB%B6Bug.html * Update date-picker.css reply to the reviewe of #7567 (ElemeFE/element#7567) * Update picker-panel.css remove the previous fix after the review of #7567(ElemeFE/element#7567) * Update date-picker.css * Update picker-panel.css
element-bot
added a commit
to ElementUI/theme-default
that referenced
this pull request
Oct 23, 2017
…7567) * Update picker-panel.css fix "last item been overlapped by footbar bug" when sidebar items are two more。even overflow can not resolve this problem, it is not the same thing. the details you can see https://dulinrain.github.io/elementui/ElementUI%E4%B9%8B%E6%97%B6%E9%97%B4%E6%8F%92%E4%BB%B6Bug.html * Update date-picker.css reply to the reviewe of #7567 (ElemeFE/element#7567) * Update picker-panel.css remove the previous fix after the review of #7567(ElemeFE/element#7567) * Update date-picker.css * Update picker-panel.css
bluejfox
added a commit
to setariajs/setaria-ui
that referenced
this pull request
Feb 5, 2018
Merge commit '762f337b2c8eac32eb1cc85c4af1e7718973cdeb' into current * commit '762f337b2c8eac32eb1cc85c4af1e7718973cdeb': (111 commits) [release] 1.4.8 [build] 1.4.8 Changelog: update for 1.4.8 (ElemeFE#7683) Dropdown: allow change show/hide timeout by props (ElemeFE#7621) Update form.md Update form.md DateTimePicker: fix hidden last item of sidebar (ElemeFE#7567) update beta notice update Readme.md Menu: fix close menu bug minor fixes for select, message-box and textarea Update package.json [release] 1.4.7 [build] 1.4.7 Changelog: update for 1.4.7 Switch: Add `allowFocus` prop & focus/blur events (ElemeFE#7494) fix ElemeFE#5813 Table: Add `important` rule to `col-resize` cursor (ElemeFE#7381) Form-item: fix "required" attribute is not effective for validation add 2.0 alpha notification ... # Conflicts: # CHANGELOG.zh-CN.md # README.md # examples/versions.json # package.json # packages/loading/src/directive.js # packages/loading/src/index.js # src/index.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix "last item been overlapped by DateTimePicker's footerbar bug" when sidebar items are too more。Even overflow can not solve this problem, it is not the same thing.
the details you can see https://dulinrain.github.io/elementui/ElementUI%E4%B9%8B%E6%97%B6%E9%97%B4%E6%8F%92%E4%BB%B6Bug.html
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.