date-range support select reverse #8156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wacky6
reviewed
Nov 16, 2017
|
|
||
| this.$emit('pick', { minDate, maxDate: this.maxDate }, false); | ||
| this.$emit('pick', { minDate, maxDate: this.minDate }); |
There was a problem hiding this comment.
这是第二次点击了，已经有了minDate了，现在的newDate比minDate小（也就是往前选日期）。现在element只支持往后选择日期区间，没法往前选
|
建议给这个情景写测试代码 |
|
@wacky6 除了测试以外，这个 PR 还有其他问题吗？ |
|
我在本地跑了一下，基本功能没什么问题。 |
|
CI 的 badge 应该 bug 了没同步过来。这个功能的测试 merge 进去了我再补吧 |
|
好的，拜托了。我这边先合了。 |
wacky6
added a commit
to wacky6/element
that referenced
this pull request
Nov 10, 2018
this is a regression introduced in pr ElemeFE#8156, which allows disabled date to be highlighted. Also simplifies handleClick's implementation to avoid DOM operations.
wacky6
added a commit
to wacky6/element
that referenced
this pull request
Nov 10, 2018
this is a regression introduced in pr ElemeFE#8156, which allows disabled date to be highlighted. Also simplifies handleClick's implementation to avoid DOM operations.
ziyoung
pushed a commit
that referenced
this pull request
Nov 12, 2018
* date-table: simplify implementation, fix #12980 * date-table: remove rangeState's row and column * date-table: fix disabled cell highlight this is a regression introduced in pr #8156, which allows disabled date to be highlighted. Also simplifies handleClick's implementation to avoid DOM operations.
weisiren168
pushed a commit
to weisiren168/element
that referenced
this pull request
Jun 20, 2019
…lemeFE#13374) * date-table: simplify implementation, fix ElemeFE#12980 * date-table: remove rangeState's row and column * date-table: fix disabled cell highlight this is a regression introduced in pr ElemeFE#8156, which allows disabled date to be highlighted. Also simplifies handleClick's implementation to avoid DOM operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.日期区间选择天的时候，可以往前选