Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree node can drag and drop #9251

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Tree node can drag and drop #9251

merged 1 commit into from
Mar 20, 2018

Conversation

elfman
Copy link
Contributor

@elfman elfman commented Jan 12, 2018

为Tree组件添加拖拽功能

@uniquejava
Copy link

I need this functionality, any plan to merge. 👍

@@ -21,6 +21,12 @@
transform: translate(-50%, -50%);
color: mix($--color-primary, rgb(158, 68, 0), 50%);
}

.dropGap {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 className需要加前缀,另外 dropGap 不是个很好的名字,叫 el-tree--drop-indicator 可能更合理。

@@ -77,6 +87,10 @@
return {};
}
},
dragEnable: {
type: Boolean,
default: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码风格里面 , 应该是不需要的。

@@ -80,6 +87,11 @@
type: Boolean,
default: false
},
dragEnable: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

draggable 可能更通俗易懂一些。

type: Boolean,
default: false
},
canDrop: Function,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allowDrop 吧

@furybean furybean merged commit d7c4fd2 into ElemeFE:dev Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants