DatePicker: fix incorrect interaction on range change when defaultTime provided #9310
Conversation
test/unit/specs/date-picker.spec.js
Outdated
| expect(maxDate.getMinutes()).to.be.equal(0); | ||
| expect(maxDate.getSeconds()).to.be.equal(0); | ||
| done(); | ||
| expect(rightCell.className.split(' ').indexOf('in-range') >= 0).to.be.true; |
There was a problem hiding this comment.
How about using classList ?
There was a problem hiding this comment.
I'm not sure about the browser support requirement of element. But it is safer to use className and almost the same complex.
There was a problem hiding this comment.
Tests are executed in Chrome. so I don't think this will be an issue.
There was a problem hiding this comment.
Maybe possible future e2e tests in different browsers? If browser supporting has never become an issue when writing test cases in this project, I'll use classList.contains instead.
There was a problem hiding this comment.
You can safely use classList. 2.0 requires ie >10 which supports it. see https://developer.mozilla.org/en-US/docs/Web/API/Element/classList
| const defaultTime = this.defaultTime || []; | ||
| this.minDate = modifyWithGivenTime(val.minDate, defaultTime[0]); | ||
| this.maxDate = modifyWithGivenTime(val.maxDate, defaultTime[1]); | ||
| this.minDate = val.minDate; |
There was a problem hiding this comment.
I think it's better to "trim" time before passing {min, max}Date to date-table.
There was a problem hiding this comment.
I cancelled my previous changes here to fix this issue (now it's just the same behavior as what it used to be). If we want to add trim behavior before passing minDate / maxDate to date-table, maybe that should be another issue?
There was a problem hiding this comment.
Actually, I mean resetting the time to 00:00:00 before passing minDate/maxDate to date-table.
date-table checks date equality in a naive way, so it can not handle non 00:00:00 time. But the rest of date-range panel should know about the selected time.
Like this:
<date-table :min-date="resetTime(minDate)">
There was a problem hiding this comment.
That makes sense. Thx.
There was a problem hiding this comment.
Seems it is a little complex to realize this.
-
I have to reset to
12:00:00to make it work (I'm still looking into why), which will change the default behavior on pick. -
There is some "reference equal" issue, which means, when
resetTimereturns a newDateobject (even with the same time value), it breaks.
I'll spend time on it later. If you have any ideas about the above problems, plz hint me.
There was a problem hiding this comment.
Interesting. Might have something to do with legacy codes. I suggest you keep current solution, it works. :)
nighca
force-pushed
the
debug-date-picker-default-time
branch
from
481a62e to
b3ad2a6
Compare
|
IE11 下 dafaulttime 根本无效，麻烦好好测试一下，只支持chrome的组件真的没什么卵用 |
Fix interaction issue introduced in #9094 (comment)
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.