Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckBox: fix issue #9677 #9746

Merged
merged 1 commit into from
Feb 10, 2018
Merged

CheckBox: fix issue #9677 #9746

merged 1 commit into from
Feb 10, 2018

Conversation

linjiajian999
Copy link
Contributor

@linjiajian999 linjiajian999 commented Feb 8, 2018

Fixed #9677

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

issue #9677中,实际上不是table组件的bug,而是checkbox组件中,input设置left: -999px后,当label获得焦点的时候,焦点会到input上,而input实际上是left-999px的,所以滚动条会往左边移动。因此需要去除掉input的定位偏差,否则在父容器有滚动条的时候,每次点击,父容器的滚动条都会被移动。

这里是重现bug的代码

@Leopoldthecoder Leopoldthecoder merged commit c726289 into ElemeFE:dev Feb 10, 2018
bluejfox added a commit to setariajs/setaria-ui that referenced this pull request Apr 16, 2018
Merge commit 'ec30f9c67d30522d3d054a8433abf5934df90fe7' into current

* commit 'ec30f9c67d30522d3d054a8433abf5934df90fe7': (44 commits)
  Chore: update package.json to lock lint config and fix console lint errors (ElemeFE#9773)
  Chore: update contribution guide (ElemeFE#9803)
  Doc: update changelogs (ElemeFE#9802)
  Menu: update es doc (ElemeFE#9801)
  Docs: update es docs for 2.2.0 (ElemeFE#9796)
  [release] 2.2.0
  [build] 2.2.0
  Changelog: update for 2.2.0 (ElemeFE#9793)
  Select: add popper-append-to-body (ElemeFE#9782)
  ColorPicker: declare box-sizing for panel (ElemeFE#9780)
  Chore: replace var with let and const (ElemeFE#9774)
  Menu: improve vertical collapse transition (ElemeFE#9777)
  support menu disabled (ElemeFE#9771)
  Popper: fix memory leak on route change (ElemeFE#9757)
  i18n: add Kurdish translation (ElemeFE#9582)
  CheckBox: hide the native input using z-index (ElemeFE#9746)
  Switch: fix click event triggering twice (ElemeFE#9760)
  Transfer: add clearQuery (ElemeFE#9753)
  Chore: update docs for Tree and Menu (ElemeFE#9751)
  Menu: support multi level submenu in horizontal mode (ElemeFE#9741)
  ...

# Conflicts:
#	CHANGELOG.zh-CN.md
#	README.md
#	build/bin/version.js
#	build/deploy-ci.sh
#	examples/versions.json
#	package.json
#	packages/tree/src/tree-node.vue
#	src/index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants