Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support SIGHASH_RANGEPROOF #270

Conversation

k-matsuzawa
Copy link
Contributor

ElementsProject/elements#960

Please use it if you like.
As for the integration tests in Elementsd, we performed them with the library using libwally-core.

Thanks!

@jgriffiths
Copy link
Contributor

jgriffiths commented Apr 5, 2021

Hi @k-matsuzawa Thanks for this!

Can you please review ecc30ad which is 2 tiny changes to this changeset?

If that looks good I will squash and merge the two commits after testing against our various CI runs for regressions (this may take a little while). I particularly need to ensure that SIGHASH_FORKID isn't broken by this change as it uses the same bitflag value.

From reviewing I would be happier with some tests in tree, particularly for the SIGHASH_SINGLE and non-segwit cases. Hopefully they can be added in due course.

@k-matsuzawa
Copy link
Contributor Author

Thank you!

I reviewed it! It's a nice fix.
The condition check on line 2224 was wrong omitted when copying. Thanks! 🙏

I look forward to getting better fixes.

@jgriffiths
Copy link
Contributor

Hi @k-matsuzawa I will close this and test/track it under #272 (which has another trivial fix if you want to bring that back to your branch). Thanks again :)

@jgriffiths jgriffiths closed this Apr 5, 2021
@jgriffiths jgriffiths mentioned this pull request Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants