db: Set the failonion to the default value on creation

This ensures that after the migration in the previous commit we never insert a new htlc with a null value. Fixes: #4363 Reported-by: Zoltán Gálli <@gallizoltan> Changelog-Fixed: db: Fixed an access to a NULL-field in the `channel_htlcs` table and resulting warning.
ElementsProject · Feb 25, 2021 · 6252930 · 6252930
1 parent 2c1411a
commit 6252930
Show file tree

Hide file tree

Showing 4 changed files with 72 additions and 71 deletions.
diff --git a/wallet/db_postgres_sqlgen.c b/wallet/db_postgres_sqlgen.c
diff --git a/wallet/db_sqlite3_sqlgen.c b/wallet/db_sqlite3_sqlgen.c
diff --git a/wallet/statements_gettextgen.po b/wallet/statements_gettextgen.po
diff --git a/wallet/wallet.c b/wallet/wallet.c
@@ -1954,7 +1954,8 @@ void wallet_htlc_save_out(struct wallet *wallet,
 		" payment_key,"
 		" hstate,"
 		" routing_onion,"
-		" partid) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?);"));
+		" malformed_onion,"
+		" partid) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 0, ?);"));
 
 	db_bind_u64(stmt, 0, chan->dbid);
 	db_bind_u64(stmt, 1, out->key.id);