payalgo: Be willing to overpay up to maxfeepercent, for privacy. #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZmnSCPxj
force-pushed
the
overpay
branch
2 times, most recently
from
7e85253 to
d5a83ee
Compare
lightningd/payalgo.c
Outdated
| /* We will never generate the maximum computed | ||
| * overpayment this way. Maybe OK for most | ||
| * purposes. */ | ||
| overpayment = overpayment % maxoverpayment; |
There was a problem hiding this comment.
We have pseudorand for this, which makes this code neater and also indicates we don't need cryptographic randomness. We only use randombytes_buf() above because we don't have a routine to give us a pseudorandom siphash seed, but that would be trivial to implement too.
if (maxoverpayment > 0)
overpayment = pseudorand(maxoverpayment);
else
overpayment = 0;
This obscures how far an intermediate hop is from the ultimate payee, and also obscures slightly the exact payment value. Fixes: ElementsProject#1089
|
ping! |
|
ACK 1c84a33 |
This was referenced Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This obscures how far an intermediate hop is from the ultimate
payee, and also obscures slightly the exact payment value.
Fixes: #1089