No bad gossip after close #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
…ossip! It currently works because we inject it so fast that it's still doing the txout lookup, but that's about to change. Signed-off-by: Rusty Russell <[email protected]>
…re options. And drive-by fix: document that you can now (since e40f078) use --max-messages=0. Signed-off-by: Rusty Russell <[email protected]>
This correctly refreshes the txout entry against aging. Signed-off-by: Rusty Russell <[email protected]>
This prevents a gratuitous lookup of we get a late channel_announce, but even better, it suppresses the "bad gossip" messages in case of a late channel_update, which have plagued Travis (especially since we got aggressive in pushing our own updates). Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/no-bad-gossip-after-close
branch
from
48c84d9 to
f1cc777
Compare
Reduce test_feerate_stress iterations, and simply don't run test_pay_retry under VALGRIND with SLOW_MACHINE at all. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/no-bad-gossip-after-close
branch
from
c7cd381 to
1e244d5
Compare
niftynei
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test fixes and an actual gossipd improvement which also fixes tests.
Changelog-none: no user-visible changes