Code

HTLC error cleanup#3472

Code

Merged

rustyrussell merged 16 commits intoElementsProject:masterElementsProject/lightning:masterfrom rustyrussell:htlc-error-cleanuprustyrussell/lightning:htlc-error-cleanupCopy head branch name to clipboardFeb 25, 2020

+934-931

Commits

Commits on Feb 24, 2020

• lightningd: rename htlc_in and htlc_out failuremsg fields to failonion.

  Show description for 36f93ce
  rustyrussell

  committed
  36f93ce

  Copy full SHA for 36f93ce

• lightningd: clean up weird call to send_htlc_out.

  Show description for 9d8bc21
  rustyrussell

  committed
  9d8bc21

  Copy full SHA for 9d8bc21

• channeld: don't get details of our own failed htlcs at init.

  Show description for 45308b8
  rustyrussell

  committed
  45308b8

  Copy full SHA for 45308b8

• lightningd: handle fail_htlc_in with no known outgoing channel.

  Show description for 832a5c2
  rustyrussell

  committed
  832a5c2

  Copy full SHA for 832a5c2

• gossipd: provide (stripped) channel_update when resolving a channel.

  Show description for c9f5dc2
  rustyrussell

  committed
  c9f5dc2

  Copy full SHA for c9f5dc2

• channeld: get the onionreply back from lightningd for failed htlcs.

  Show description for 6d0f6f0
  rustyrussell

  committed
  6d0f6f0

  Copy full SHA for 6d0f6f0

• lightningd: remove always-NULL argument to add_fail.

  Show description for 6fab127
  rustyrussell

  committed
  6fab127

  Copy full SHA for 6fab127

• wallet: Add new htlc column "localfailmsg" for outgoing htlcs.

  Show description for 5b7d83f
  rustyrussell

  committed
  5b7d83f

  Copy full SHA for 5b7d83f

• channeld: add routing to get our own channel's channel_update.

  Show description for 8a18d9f
  rustyrussell

  committed
  8a18d9f

  Copy full SHA for 8a18d9f

• lightningd: store raw msg rather than code for locally-failed outgoing HTLCs

  Show description for eb5eeb6
  rustyrussell

  committed
  eb5eeb6

  Copy full SHA for eb5eeb6

• lightningd: separate path for failed_htlc when an onion is bad.

  Show description for ea23f9b
  rustyrussell

  committed
  ea23f9b

  Copy full SHA for ea23f9b

• lightningd: make local htlc failures pass a wiremsg for errors, not a failcode.

  Show description for 82613d4
  rustyrussell

  committed
  82613d4

  Copy full SHA for 82613d4

• lightningd: always use an onionreply for locally generated incoming HTLC errors (unless BADONION).

  Show description for 953a583
  rustyrussell

  committed
  953a583

  Copy full SHA for 953a583

• wallet: only store BADONION codes in db for incoming htlcs: rest are all onionreplyies.

  Show description for 8bf6393
  rustyrussell

  committed
  8bf6393

  Copy full SHA for 8bf6393

• lightningd: rename htlc_in field from failcode to badonion.

  Show description for c07e1aa
  rustyrussell

  committed
  c07e1aa

  Copy full SHA for c07e1aa

• plugins: support failure_message in invoice and htlc_accepted hooks.

  Show description for 4dbeac8
  rustyrussell

  committed
  4dbeac8

  Copy full SHA for 4dbeac8