Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning-cli cleanups #3722

Merged
merged 3 commits into from
May 15, 2020
Merged

Conversation

rustyrussell
Copy link
Contributor

No description provided.

-H removes the top-level if there's only one, and 'format-hint'
breaks this heuristic, so we end up with:

```
help=command=autocleaninvoice [cycle_seconds] [expired_by]
category=plugin
description=Set up autoclean of expired invoices.
verbose=Perform cleanup every {cycle_seconds} (default 3600), or disable autoclean if 0. Clean up expired invoices that have expired for {expired_by} seconds (default 86400).
command=check command_to_check
```

Signed-off-by: Rusty Russell <[email protected]>
Much nicer for grepping, since `{ "foo": { "bar": [7] } }` is turned into
`foo.bar[0]=7`.

Changelog-Added: cli: New `--flat` mode for easy grepping.
Signed-off-by: Rusty Russell <[email protected]>
1. help now uses a boutique format, not -H.
2. document the -F option.

Signed-off-by: Rusty Russell <[email protected]>
@rustyrussell rustyrussell requested a review from cdecker as a code owner May 11, 2020 01:13
@cdecker
Copy link
Member

cdecker commented May 12, 2020

How does this interact with #3719? Could it be that this also addresses the issue in #3719?

@rustyrussell
Copy link
Contributor Author

Yes: the problems addressed by #3719 are what made me look at this again. But #3719 is still needed, and serves as a nice backport since it will work with existing c-lightning nodes so I think we should apply that as is.

@cdecker
Copy link
Member

cdecker commented May 15, 2020

ACK a7ee492

@cdecker cdecker merged commit 3c625b3 into ElementsProject:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants