Code

Inflights ordering, crashfix #4521

Code

Merged

rustyrussell merged 20 commits intoElementsProject:masterElementsProject/lightning:masterfrom niftynei:nifty/rbf-err-fixniftynei/lightning:nifty/rbf-err-fixCopy head branch name to clipboardMay 24, 2021

+985-357

Commits

Commits on May 19, 2021

• df-test: test for a failed rbf attempt, currently crashes

  Show description for 0ce2cc3
  niftynei

  committed
  0ce2cc3

  Copy full SHA for 0ce2cc3

• df-tests: add better explainer for test logic

  niftynei

  committed
  6b88e97

  Copy full SHA for 6b88e97

• df-rbf: order inflights by funding_feerate

  Show description for 8eca244
  niftynei

  committed
  8eca244

  Copy full SHA for 8eca244

Commits on May 21, 2021

• inflights: add checks that there's actually an inflight

  niftynei

  committed
  fbc556c

  Copy full SHA for fbc556c

• listpeers: add inflights info

  Show description for d9313b2
  niftynei

  committed
  d9313b2

  Copy full SHA for d9313b2

• df-rbf: test that, with enough bumps, we can eventually add to mempool

  Show description for b8e7fcb
  niftynei

  committed
  b8e7fcb

  Copy full SHA for b8e7fcb

• rbf: on close, drop every inflight transaction's commitment

  Show description for a296e01
  niftynei

  committed
  a296e01

  Copy full SHA for a296e01

• listpeers: show the inflight's 'commitment tx' txid

  Show description for 8c904cc
  niftynei

  committed
  8c904cc

  Copy full SHA for 8c904cc

• listpeers: always show all the inflights

  Show description for 2bdf27f
  niftynei

  committed
  2bdf27f

  Copy full SHA for 2bdf27f

• dev-sign-last-tx: include inflight signed txs

  Show description for 689e6e9
  niftynei

  committed
  689e6e9

  Copy full SHA for 689e6e9

• inflights: save the whole psbt to the database

  Show description for 125739d
  niftynei

  committed
  125739d

  Copy full SHA for 125739d

• rbf-tests: check every inflight has signed commitment produced

  Show description for 18df398
  niftynei

  committed
  18df398

  Copy full SHA for 18df398

• open-rbf: we broadcast all the commitments for a channel when closed

  Show description for da60f41
  niftynei

  committed
  da60f41

  Copy full SHA for da60f41

• inflights: relax assertion channel funding_txid is last inflight txid

  Show description for df2edec
  niftynei

  committed
  df2edec

  Copy full SHA for df2edec

• rbf: update the channel's funding_txid to match what's mined

  Show description for 2270edd
  niftynei

  committed
  2270edd

  Copy full SHA for 2270edd

• rbf: when a channel is open, remove all the inflights

  Show description for 6da93d4
  niftynei

  committed
  6da93d4

  Copy full SHA for 6da93d4

• rbf: when a peer is activated, also keep track of all of its inflights

  Show description for 9f28405
  niftynei

  committed
  9f28405

  Copy full SHA for 9f28405

• nit: add another debug log

  Show description for 97e9143
  niftynei

  committed
  97e9143

  Copy full SHA for 97e9143

• rbf-test: confirm that rbf'd inflight is opened and closed as expected

  Show description for 30166ed
  niftynei

  committed
  30166ed

  Copy full SHA for 30166ed

• dual-open: save our now updated info about broadcast state

  niftynei

  committed
  2d4f3d0

  Copy full SHA for 2d4f3d0