make: Add msggen generated files to check-gen-updated target #5415
Conversation
There was a problem hiding this comment.
ACK 024bfa1 but I admit that I'm not a big fun of mixing required stuff with not required one.
|
Oh my, sorry I managed to commit one of the files that I used for testing. Will remove that asap. As for required and optional, in this case it doesn't really matter, either we have rust in which case we might regenerate and cause an error because we forgot, or we don't have rust in which case we won't regenerate and therefore can't cause an error. |
|
Love the idea... it was supposed to fail on master, right? Weird that there's a python diff in there though... hmm....? Ack 024bfa1 |
|
Yep, I'll retire libhsmd_python as noone is using it, and add the latest version of the files before merging. |
This has been replaced with better rust bindings that can then be consumed via pyo3, consolidating the C interface in a portable wrapper. Changelog-Removed: libhsmd: Removed the `libhsmd_python` wrapper as it was unused
|
Removed |
There was a problem hiding this comment.
ACK 711f339
noticed that the all but 2 of the doc/*.7 files aren't checked into git, therefore check-gen-updated doesn't fail for them.
imho this need to be done inside the docs CI because otherwise there is no possibility to run the CI is we are working in a rpc command update without changing the docs.
Changing rpc command it is not too frequent yes this is true!
|
We should not be checking in any generated files: should git rm those two as well! |
This is a coutnerproposal to #5356 which uses the existing CI jobs and targets to check we committed all changes.