cln: remove wumbo check because CLN >=v23.11 defaults to enabling it #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nepet
reviewed
Jan 11, 2024
| @@ -137,7 +137,6 @@ test-misc-integration: test-bins | |||
| 'Test_RestoreFromPassedCSV|'\ | |||
| 'Test_Recover_PassedSwap_BTC|'\ | |||
| 'Test_Recover_PassedSwap_LBTC|'\ | |||
| 'Test_Wumbo|'\ | |||
There was a problem hiding this comment.
Is the wumbo test also used in a different place or can we remove the test completely from the tests?
There was a problem hiding this comment.
I didn't feel 100% comfortable removing wumbo_test.go too just in case it was used elsewhere. Pretty certain it is fine to remove it though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest CLN ignores
large-channels/wumboconfig options and does not pass them to PeerSwap. PeerSwap checks for this config option and cancels large swaps if it is missing. This PR removesClnMaxPaymentSizeMsatand the check since we don't need it anymore for CLN >=23.11.Fixes #261