Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v10 Conversion #40

Merged
merged 6 commits into from
Oct 30, 2022
Merged

v10 Conversion #40

merged 6 commits into from
Oct 30, 2022

Conversation

EndlesNights
Copy link
Contributor

Have not fully tested everything about, but get the module support for Foundry v10.

src/module.json Outdated
"minimumCoreVersion": "9",
"compatibleCoreVersion": "9",
"minimumSystemVersion": "1.4.0",
"minimumSystemVersion": "2.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe this has been replaced with something in relationships

@EndlesNights
Copy link
Contributor Author

EndlesNights commented Oct 20, 2022

You're right, it should now be:

	"relationships": {
		"systems": [
			{
				"id": "dnd5e",
				"type": "system",
				"manifest": "https://raw.githubusercontent.com/foundryvtt/dnd5e/master/system.json",
				"compatibility": {
					"minimum": "2.0.0"
				}
			}
		]
	},

Copy link
Member

@akrigline akrigline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I likewise haven't tested this, but will put out a release with this code if you don't object

@akrigline akrigline merged commit f51b10b into ElfFriend-DnD:master Oct 30, 2022
@SirXen0
Copy link

SirXen0 commented Nov 9, 2022

Would love to test this, my players only use the OGL sheet and would be fine testing changes just to use the new foundry version.

@Someone2345
Copy link

At the risk of sounding like an idiot - is there a way to install and test this?
Many thanks

@mcabel
Copy link

mcabel commented Feb 3, 2023

hi, were the fixes here functional, or it ended up as buggy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants