Skip to content

Commit

Permalink
Have wasm job fail the workflow but not block auto-merge
Browse files Browse the repository at this point in the history
The WebAssembly CI job definition had an unconditional job-level
`continue-on-error` set to `true`, so that it would always report a
successful conclusion, even on failure. This made sense before PR
auto-merge was set up. But these jobs do not typically fail, and
their failures should be more apparent, even if they should not
yet block PRs from being auto-merged.

This commit changes the `wasm` jobs so they are able to fail and
cause the workflow as a whole to have a failing status, while still
not blocking PR auto-merge. `continue-on-error` is removed from the
job definition, but it is also no longer made a dependency of the
required `tests-pass` check.
  • Loading branch information
EliahKagan committed Nov 11, 2024
1 parent 87670a6 commit 253b716
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,6 @@ jobs:

runs-on: ubuntu-latest

continue-on-error: true

strategy:
matrix:
target: [ wasm32-unknown-unknown, wasm32-wasi ]
Expand Down Expand Up @@ -302,6 +300,7 @@ jobs:
# List all jobs that are intended NOT to block PR auto-merge here.
EXPECTED_NONBLOCKING_JOBS: |-
test-fixtures-windows
wasm
tests-pass
defaults:
Expand Down Expand Up @@ -338,7 +337,6 @@ jobs:
- test-32bit
- lint
- cargo-deny
- wasm
- check-packetline
- check-blocking

Expand Down

0 comments on commit 253b716

Please sign in to comment.