Skip to content

Commit

Permalink
Clarify skipped "Install packages (Ubuntu)" step
Browse files Browse the repository at this point in the history
- Slightly reword and reformat the block comment.

- Run two commands instead of using `&&`, since with `shell: bash`
  (inherited as the default as specified at the workflow level),
  the actual shell command invoked for script steps includes `-e`,
  so the script would still immediately fail if the first command
  fails.
  • Loading branch information
EliahKagan committed Aug 1, 2024
1 parent fb232d1 commit 264076b
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -174,11 +174,13 @@ jobs:
uses: actions/checkout@v4

- name: Install packages (Ubuntu)
# Because openssl doesn't work on musl by default, we resort to max-pure. And that won't need any dependency, so we can skip this.continue-on-error
# Because openssl doesn't work on musl by default, we resort to max-pure.
# And that won't need any dependency, so we can skip this or use `continue-on-error`.
# Once we want to support better zlib performance, we might have to re-add it.
if: matrix.os == 'ubuntu-latest-disabled'
run: |
sudo apt-get update && sudo apt-get install -y --no-install-recommends xz-utils liblz4-tool musl-tools
sudo apt-get update
sudo apt-get install -y --no-install-recommends xz-utils liblz4-tool musl-tools
- name: Install Rust
uses: dtolnay/rust-toolchain@master
Expand Down

0 comments on commit 264076b

Please sign in to comment.