Skip to content

Commit

Permalink
Clarify messages
Browse files Browse the repository at this point in the history
This is mainly to avoid the effect of specifically recommending
that the release version/name (usually taken from a tag) be
changed to match the version in Cargo.toml, which would not always
be good advice because it may be that the version in Cargo.toml
is wrong, or that both are wrong, or in testing that a specially
named tag (or `VERSION` environment variable) should be used.
  • Loading branch information
EliahKagan committed Aug 1, 2024
1 parent f51e778 commit bade231
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,19 @@ jobs:
case "$VERSION" in
"v$manifest_version" )
echo 'OK: Version to name the relase agrees with top-level Cargo.toml.'
echo 'OK: Release name/version agrees with Cargo.toml version.'
;;
TEST-* | *-DO-NOT-USE )
echo 'OK: Version to name the release is strange but marked as such.'
echo 'OK: Release name/version is strange but marked as such.'
;;
"$manifest_version" )
echo 'STOPPING: Version to name the release is missing the leading "v".'
echo 'STOPPING: Release name/version is missing the leading "v".'
exit 1
;;
* )
echo 'STOPPING: Version to name the release seems mistaken.'
echo 'STOPPING: Release name/version and Cargo.toml version do not match.'
echo 'STOPPING: Usually this means either a wrong tag name or wrong version in Cargo.toml.'
echo 'STOPPING: If intended, prepend `TEST-` or append `-DO-NOT-USE` to the release name.'
exit 1
;;
esac
Expand Down

0 comments on commit bade231

Please sign in to comment.