Skip to content

Commit

Permalink
Say why we test gix-hashtable instead of gix on armv7
Browse files Browse the repository at this point in the history
This completes the TODO about investigating what was thought to be
an environment error, possibly because it references `LD_PRELOAD`.
We can't run `cross test -p gix --target armv7-linux-androideabi`
because the armv7 `bash` that runs the test fixture scripts (whose
archives are `.gitignore`d) finds the `git` command on the runner,
which is an amd64 build, and tries to run it as though it is a
dynamically linked armv7 executable. This relates to the use of
`cross`; no analogous problem occurs with the i686 builds, which
are able to run the amd64 `git` avaialble on the system.

There are various ways to try to fix this, but for now we do not
have any such fix and this is putting it back to testing with
`-p gix-hashtable` on armv7 (while still using `-p gix` on i686),
and also replacing the old TODO comment with comments on the newly
introduced matrix variable about why `gix` is tested on one target
and `gix-hashtable` is tested on another.
  • Loading branch information
EliahKagan committed Nov 17, 2024
1 parent 6771838 commit e94526e
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,10 @@ jobs:
include:
- target: i686-unknown-linux-musl
cargo: cargo
package-to-test: gix # Without cross, can test gix. Fixture scripts use amd64 git.
- target: armv7-linux-androideabi
cargo: cross
package-to-test: gix-hashtable # With cross, can't test gix. Fixture scripts need armv7 git.
fail-fast: false # FIXME: Remove this after testing.

steps:
Expand All @@ -227,9 +229,8 @@ jobs:
- name: check
run: ${{ matrix.cargo }} check -p gix --target ${{ matrix.target }}
- name: Test (unit)
# run high-level unit tests that exercise a lot of code while being pure Rust to ease building test binaries.
# TODO: figure out why `git` doesn't pick up environment configuration so build scripts fail when using `-p gix`.
run: ${{ matrix.cargo }} test -p gix --target ${{ matrix.target }}
# Run high-level unit tests that exercise a lot of code while being pure Rust to ease building test binaries.
run: ${{ matrix.cargo }} test -p ${{ matrix.package-to-test }} --target ${{ matrix.target }}

lint:
runs-on: ubuntu-latest
Expand Down

0 comments on commit e94526e

Please sign in to comment.