Fix nested any/all evaluation #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current evaluator pops everything on the stack in order to evaluate `any` or `all` queries. That breaks in nested situations like: ``` all(any(unix, target_arch="x86"), not(any(target_os="android", target_os="emscripten"))) ``` Fix this by tracking the number of predicates in the `Any` and `All` variants. This unfortunately breaks semver because the definition of `Func` changes. `Func` doesn't seem to be exported anywhere so maybe in the upcoming release it could be made private?
Jake-Shadle
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
The current evaluator pops everything on the stack in order to evaluate
anyorallqueries. That breaks in nested situations like:Fix this by tracking the number of predicates in the
AnyandAllvariants.This unfortunately breaks semver because the definition of
Funcchanges.Funcdoesn't seem to be exported anywhere so maybe in the upcoming releaseit could be made private?