Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the context definition for 32bit linux. #71

Merged
merged 9 commits into from
Mar 31, 2023
Merged

Fix the context definition for 32bit linux. #71

merged 9 commits into from
Mar 31, 2023

Conversation

afranchuk
Copy link
Contributor

i64 rather than i32 was accidentally used for the general registers.

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

The x86 context general registers have been changed to be i32.

@afranchuk
Fix the context definition for 32bit linux.
c90a058 
i64 rather than i32 was accidentally used for the general registers.
@afranchuk afranchuk requested a review from Jake-Shadle as a code owner March 31, 2023 15:39
Jake-Shadle
Jake-Shadle approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops.

@mergify mergify bot merged commit 5c836a2 into EmbarkStudios:main Mar 31, 2023
@afranchuk
Copy link
Contributor Author

That's a good set of clippy fixes 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jake-Shadle Jake-Shadle Jake-Shadle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afranchuk @Jake-Shadle