-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package ID parsing panics #72
Comments
I have just found this related issue that was closed, but it looks like the fix might not have been complete, as failures do still happen: #64 |
If you run cargo deny on stable cargo instead of nightly it will work. |
Thanks, that can be a workable workaround until this is sorted out, but I'm explicitly interested in the nightly Rust toolchain because it comes with more powerful versions of Clippy and rustfmt. |
This is a temporary workaround until EmbarkStudios/krates#72 is solved.
Describe the bug
Parsing the package ID
git+https://github.com/ComunidadAylas/glsl-lang#0.5.2
panics whenkrates
0.16.3 is used transitively bycargo deny
with the following message:As a consequence of this,
cargo deny
is currently non-functional in my environment.To Reproduce
Steps to reproduce the behavior:
EmbarkStudios/cargo-deny-action@c9a2a6316320da223aaf3b59d1ac70572e8cf1f8
GitHub action in a step, that has a transitive dependency onkrates
.Expected behavior
Given that Cargo deals with these package IDs fine (i.e., my dependency metadata files are not corrupt),
krates
should just work, or at least not fail in this way (why was the Clippy lint warning against a panickingFrom
implementation disabled?).Screenshots
https://github.com/ComunidadAylas/PackSquash/actions/runs/7608744547/job/20718541200
Device:
Additional context
From the perspective of an user of the
cargo deny
GitHub Action, this is a fairly recent regression.EmbarkStudios/cargo-deny-action@1e59595
worked fine for me with Rust version 1.77.0-nightly (714b29a17 2024-01-15).Rust version: 1.77.0-nightly (ef71f1047 2024-01-21)
The text was updated successfully, but these errors were encountered: