-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support glam and macaw types #85
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -80,3 +80,52 @@ __private_derive_reflect_foreign! { | |
end: Idx, | ||
} | ||
} | ||
|
||
#[cfg(feature = "glam")] | ||
mod glam_impls { | ||
use glam::{Mat3, Vec2, Vec3}; | ||
use mirror_mirror_macros::__private_derive_reflect_foreign; | ||
|
||
__private_derive_reflect_foreign! { | ||
#[reflect(crate_name(crate))] | ||
pub struct Vec2 { | ||
pub x: f32, | ||
pub y: f32, | ||
} | ||
} | ||
|
||
__private_derive_reflect_foreign! { | ||
#[reflect(crate_name(crate))] | ||
pub struct Vec3 { | ||
pub x: f32, | ||
pub y: f32, | ||
pub z: f32, | ||
} | ||
} | ||
|
||
// `Vec4`, `Quat`, and `Mat2` are left out because glam uses bad hacks which changes the struct | ||
// definitions for different architectures (simd vs no simd) and cargo features. So we'd have | ||
// to use the same hacks in mirror-mirror which I'd like to avoid. | ||
|
||
// `Mat4` is left out because it contains `Vec4` which we don't support. | ||
|
||
__private_derive_reflect_foreign! { | ||
#[reflect(crate_name(crate))] | ||
pub struct Mat3 { | ||
pub x_axis: Vec3, | ||
pub y_axis: Vec3, | ||
pub z_axis: Vec3, | ||
} | ||
} | ||
} | ||
|
||
#[cfg(feature = "macaw")] | ||
mod macaw_impls { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto here; even if it makes for a tiny file, it's nice to have it separate from the rest of the core types imo |
||
use macaw::ColorRgba8; | ||
use mirror_mirror_macros::__private_derive_reflect_foreign; | ||
|
||
__private_derive_reflect_foreign! { | ||
#[reflect(crate_name(crate))] | ||
pub struct ColorRgba8(pub [u8; 4]); | ||
} | ||
} |
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to put this in an
glam.rs
file? It's a bit weird to have it in themod.rs
module here (I did look for it in another file when trying that PR locally.)