Skip to content
This repository has been archived by the owner on Feb 4, 2022. It is now read-only.

Rewrite in Rust #11

Closed
Jake-Shadle opened this issue May 11, 2020 · 10 comments · May be fixed by #21
Closed

Rewrite in Rust #11

Jake-Shadle opened this issue May 11, 2020 · 10 comments · May be fixed by #21
Labels
enhancement New feature or request

Comments

@Jake-Shadle
Copy link
Member

This crate basically provides a thin wrapper around the nativefiledialog C library, which itself is just a small abstraction on top of the OS dialogs. While nativefiledialog is small and easy to build, there's really no good reason why we can't go directly to the OS dialogs inside Rust without needing to have a submodule/wrapper for a C library.

@Jake-Shadle Jake-Shadle added the enhancement New feature or request label May 11, 2020
@repi
Copy link

repi commented May 11, 2020

I have a crate that is a start for that and that does it natively for Windows and that works really well, but we would need to implement Linux and MacOS support, which is a bit messy.

@PolyMeilex
Copy link

PolyMeilex commented May 26, 2020

I had working Linux and Windows crate laying somewhere on my hard drive, but I abandoned it because I have no way to test macOS implementation
It's totally doable, and it does not require that much work, so let me know if you decide to work on project like this.

@adamnemecek
Copy link

@PolyMeilex @repi why don't you guys post these online?

@PolyMeilex
Copy link

PolyMeilex commented Oct 10, 2020

Sure, for anyone interested here is my project (for win,gtk,macos and wasm) https://github.com/PolyMeilex/rfd
It also supports async/await syntax, which helps a lot with macOS dialogs, as those can't be multi threaded.
Feel free to give it a try.

@repi
Copy link

repi commented Aug 25, 2021

hi @PolyMeilex, @emilk in our team have switch us at Embark to use your new crate now, awesome work on it!

We'll test it for a bit now across platforms and see if we run into any issues. but if it works well I think we'll close and archive this crate and repro and redirect to rfd!

@repi
Copy link

repi commented Aug 25, 2021

@PolyMeilex would be cool to collaborate on some crates and chat, ping us on our Discord or drop us a mail on [email protected] if you are interested :)

@PolyMeilex
Copy link

Hi! If you encounter any problems, or missing features in rfd fell free to open issues, I'm quite open to the scope of the crate, so as long as it's dialog related (not necessarily file dialogs) I will most likely accept it.

@parasyte
Copy link

I'll add that I used rfd's async impl with pollster in one of my projects last month and it was a super smooth experience. Just a positive experience report. I haven't noticed anything missing or any bugs to address.

@repi
Copy link

repi commented Sep 13, 2021

We've transitioned fully over to rfd now and haven't had any problems since on Windows, Mac or Linux. Thanks @PolyMeilex !

So think we can consider this issue closed. And we can close/deprecate/archive this crate and repo. Filed #22 for that.

@repi repi closed this as completed Sep 13, 2021
@PolyMeilex
Copy link

Great to hear that

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants