Enable Clippy use_self lint in spirv-std #147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #34, the use_self lint is currently disabled in spirv-std.
There is one exception to this. I had to introduce an exception in mod.rs because there is bug that confuses core::intrinsics with f32. I have opened a bug report for it over on the Clippy repo here. It seems there a few related errors where this also happens.
I'm not sure whether enabling the use_self lint is a good idea or not. The feature doesn't seem to be bug-free.