Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Clippy use_self lint in spirv-std #147

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Conversation

nipunG314
Copy link
Contributor

As mentioned in #34, the use_self lint is currently disabled in spirv-std.

There is one exception to this. I had to introduce an exception in mod.rs because there is bug that confuses core::intrinsics with f32. I have opened a bug report for it over on the Clippy repo here. It seems there a few related errors where this also happens.

#[allow(clippy::use_self)]
impl MathExt for f32 {
    fn pow(self, factor: f32) -> f32 {
    ...
}

I'm not sure whether enabling the use_self lint is a good idea or not. The feature doesn't seem to be bug-free.

Copy link
Contributor

@khyperia khyperia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! 🎉

@mergify mergify bot merged commit 75ca545 into EmbarkStudios:main Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants