fix: should early return when disassembled text is null #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if print option is on, return a default string
Jake-Shadle
approved these changes
Mar 15, 2021
| if text.is_null() && !options.print { | ||
| return Err(crate::error::Error { | ||
| if text.is_null() { | ||
| if !options.print { |
There was a problem hiding this comment.
I think this line make it strange to report an error while printing, should we accept null text as empty string for all success case?
There was a problem hiding this comment.
If print option is off, then text should not be null and error should be reported.
There was a problem hiding this comment.
This line here will not report error while printing, it is !options.print
There was a problem hiding this comment.
Whatever print or not, if ret is Success, there should be no error.
Merged
|
FYI I've changed things so that now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
in
CompiledAssembler::disassemble, if text is null and print option is on, return a empty string, otherwise it will access a null text afterwardRelated Issues
None